feat: mount pprof and metrics to /api/v2/debug for admins #20353
+41
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
approved these changes
Oct 17, 2025
| r.Get("/symbol", httppprof.Symbol) | ||
| r.Get("/trace", httppprof.Trace) | ||
|
|
||
| // Index will handle any custom runtime/pprof handlers as well. |
There was a problem hiding this comment.
Suggested change
| // Index will handle any custom runtime/pprof handlers as well. | |
| // Index will handle standard and custom runtime/pprof profiles. |
|
In essence the comment is true since only owners have that permission I believe. If you want I can change the comment to be more explicit though @mafredri |
Gotcha, if you don't mind it'd be nice to see the potential reduction of scope documented as well. PS. It looks like enterprise tests are unhappy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the following debug routes for people with the
debug_info:readpermission:/api/v2/debug/pproffornet/http/pprof//profile/symbol/trace/*except/cmdline/api/v2/debug/metricsfor Prometheus metricsSee
net/http/pprof.init: https://cs.opensource.google/go/go/+/refs/tags/go1.25.3:src/net/http/pprof/pprof.go;l=95-105