[SERVER-2194] Add job for verifying the windows executor resource classes #56

jbialy · 2022-12-22T20:33:50Z

The purpose of this PR is to add support for testing the various resource classes available for the Windows execution environment. See ticket: SERVER-2194.

Update to config version 2.1 and refactor docker resource class config block to use reusable configuration.
Define docker and windows executors
Define verify_resource_class command for performing verification actions per specific executor.
Add executor_resource_class job which accepts executor_type and resource_class params.
Add CIRCLE_WINDOWS_EXECUTOR variable for checking if the windows workflows should be executed.
Update readme.

…by executor

jbialy · 2022-12-22T20:34:03Z

PTE test with CIRCLE_WINDOWS_EXECUTOR=true:

PTE test with CIRCLE_WINDOWS_EXECUTOR not set:

.circleci/config.yml

gosuku · 2023-01-03T16:28:55Z

LGTM but for the comment that Atul made. Would be good to explicitly check for CIRCLE_WINDOWS_EXECUTOR==true

README.md

circlery

Thanks for the changes! LGTM!

jbialy · 2023-01-03T19:18:30Z

I added a card to fixed the failed jobs on k9s -> https://circleci.atlassian.net/browse/SERVER-2233

Janusz Bialy added 20 commits December 21, 2022 12:10

define reusable default executor

5709a1a

unsupported character in job name

441aeb8

extract reusable steps under commands block

bbdef07

convert resource job check to reusable blocks

0d300c4

remove config version in workflow

786eb1c

rename executor to just docker

cdbcb5f

pass resource class name to verification command

61ae6da

add windows executor config

877de29

add conditionals to different commands based on executor type

b099aa4

rename job and command reusable blocks for added clarity

a4ab315

use the correct resource class names

3340648

add windows compatible env var check and seperate resource class job …

f4c554a

…by executor

verification command for powershell in windows

f840dab

limit to windows.medium class

b44b3f4

use backtick for splitting lines in pwrshell

3b04853

fix URL and use double quotes for header key/value

699b422

add windows.large class

0e6e5d6

add condition for when the windows verification workflow jobs run

1c622ad

add windows.xlarge class

f0ad4a5

update readme

94b890a

jbialy self-assigned this Dec 22, 2022

jbialy marked this pull request as ready for review December 23, 2022 15:13

jbialy requested a review from a team December 23, 2022 15:13

Janusz Bialy added 2 commits December 23, 2022 10:44

fix typo

d3be297

remove _job from the job name

1f2306e

jbialy requested a review from gosuku January 3, 2023 14:50

atulsingh0 requested changes Jan 3, 2023

View reviewed changes

.circleci/config.yml Outdated Show resolved Hide resolved

circlery reviewed Jan 3, 2023

View reviewed changes

README.md Outdated Show resolved Hide resolved

explicitly check that windows executor flag is set to true

92f18c0

jbialy requested a review from atulsingh0 January 3, 2023 18:59

update readme to include link to windows image builder repo

bbc7f16

jbialy requested a review from circlery January 3, 2023 19:06

circlery approved these changes Jan 3, 2023

View reviewed changes

gosuku approved these changes Jan 3, 2023

View reviewed changes

atulsingh0 approved these changes Jan 3, 2023

View reviewed changes

jbialy merged commit 4beb8fc into master Jan 3, 2023

jbialy deleted the SERVER-2194-windows-resource-class branch January 3, 2023 20:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[SERVER-2194] Add job for verifying the windows executor resource classes #56

[SERVER-2194] Add job for verifying the windows executor resource classes #56

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

[SERVER-2194] Add job for verifying the windows executor resource classes #56

[SERVER-2194] Add job for verifying the windows executor resource classes #56

Uh oh!

Conversation

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants