(#3804, #1901) Add source locations to package information #3801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1239d46 to
644d0ba
Compare
corbob
commented
Oct 15, 2025
src/chocolatey/infrastructure.app/domain/ChocolateyPackageInformation.cs
Outdated
Show resolved
Hide resolved
src/chocolatey/infrastructure.app/services/ChocolateyPackageInformationService.cs
Outdated
Show resolved
Hide resolved
gep13
reviewed
Oct 16, 2025
src/chocolatey/infrastructure.app/domain/ChocolateyPackageInformation.cs
Outdated
Show resolved
Hide resolved
This commit adds the source location for a package to the .chocolatey directory, and adds the printing of the location to the `choco list` verbose output (and also `choco info --local-only`).
This commit reverts c74a19c where we had reverted the initial work to display the deployment location. As we are releasing a new version of CLE that can take this newer version as a breaking change, we can add this functionality in there too.
|
From a functionality standpoint I'm happy to approve this. I'll leave the final approval on naming and such to Gary and Paul before we call it all good, though. :3 |
vexx32
previously approved these changes
Oct 16, 2025
|
I noticed some missed renames after @vexx32 left their review. I've added one last commit, and run the Chocolatey Agent Test Kitchen suite here: https://sra-soteria-web.ch0.co/buildConfiguration/TestKitchen_ChocolateyAgent/38694. I will review the results in the morning. |
gep13
requested changes
Oct 17, 2025
gep13
previously requested changes
Oct 17, 2025
This adds pester tests to ensure the deployment location and the source repository are correctly output when running `choco info --local-only`
This commit renames the SourceInstalledFrom variable to the decided variable name. This also removes the uses of the deprecated PackageResult constructor.
This commit adds documentation to the PackageResult class, and slightly adjusts the formatting of the constructors to make them clearer.
This commit adds the license packages in the snapshot creation. Some of the licensed tests rely on the license packages to ensure it has access to the expected license files.
vexx32
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Add the source repository and deployment location to the stored Chocolatey package information, displaying it as part of
choco info --local-onlyandchoco list --verbose.Motivation and Context
See #3804 and #1901
Testing
choco install <packageName>$env:ChocolateyInstall/.chocolatey/<packageName>.<packageVersion>/.sourceInstalledFromthat it exists, and includes the repository that was used for installation.choco install <packageName> --source .$env:ChocolateyInstall/.cho 10000 colatey/<packageName>.<packageVersion>/.sourceInstalledFromthat it exists, and includes the local path that was used for installation.choco info <packageName> --local-onlyand ensure that both the deployment location and the source installed from location are listed.choco list --verboseand ensure that both the deployment location and the source installed from location are listed.Operating Systems Testing
Change Types Made
Change Checklist
Related Issue
choco infooutput #1901