fix(upbit): multiple streams #26954
Open
fix(upbit): multiple streams #26954
+33
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosmiei
reviewed
Oct 3, 2025
| const stringified = this.json (requestPart); | ||
| if (!(stringified in currentSubscriptions)) { | ||
| currentSubscriptions[stringified] = requestPart; | ||
| } |
There was a problem hiding this comment.
this isn't a good approach, if the connection crashes and restarts we still have these in options
There was a problem hiding this comment.
does current approach look good?
There was a problem hiding this comment.
aren't we still using options?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a long-standing bug, current upbit implementation doesn't support multiple streams well.
for example, you can even test out with postman, just connect to ws:
wss://api.upbit.com/websocket/v1and subscribe to any ticker:
then subscribe to any orderbook:
you will see that you will no longer receive any stream from ticker endpoint anymore and only orderbook (last subscribed stream) is coming in.
So, we probably need to always send all subscriptions in one (last) request, as also mentioned in the DOCS
fixes #17512