Nothing Special   »   [go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.x: remove loading repl plugin in bootstrap cli #941

Merged
merged 1 commit into from
Mar 2, 2023
Merged

Conversation

LordSimal
Copy link
Contributor

cakephp/repl isn't being installed by default anymore, therefore we shouldn't load it by default as well.
Refs: #878

@LordSimal LordSimal added this to the 4.x milestone Mar 1, 2023
@othercorey
Copy link
Member

Isn't that what addOptionalPlugin is for?

@garas
Copy link
Member
garas commented Mar 1, 2023

Isn't that what addOptionalPlugin is for?

It is for dev dependencies (require-dev in composer.json).

Repl in not included neither in require or require-dev, only in suggest.

@othercorey
Copy link
Member

Sure, but it's the same concept. We could just comment it out I guess.

@LordSimal
Copy link
Contributor Author

Sure, but it's the same concept. We could just comment it out I guess.

By that logic we should then optionally load

  • markstory/asset_compress and
  • dereuromark/cakephp-ide-helper

as well

@othercorey
Copy link
Member

Sure. If we're suggesting it. This is just a helpful template to show where things go, right.

@LordSimal
Copy link
Contributor Author

I am fine with either one of the solutions - either remove all or add all suggestions which are actual CakePHP plugin suggestions

@othercorey
Copy link
Member

@ADmad what do you think? I don't have a strong opinion, just thought it could be used for this.

@ADmad
Copy link
Member
ADmad commented Mar 2, 2023

I don't have a strong opinion on this either but would lean towards removing it. I don't remember anyone mentioning using the repl plugin in any of our help channels in a long time.

@ADmad
Copy link
Member
ADmad commented Mar 2, 2023

Also one major gripe I have with the repl plugin / psysh is that it pulls in a symfony package which override our dd() function.

@othercorey
Copy link
Member

Sounds good, merging since this isn't a major issue.

@othercorey othercorey merged commit e678b83 into 4.x Mar 2, 2023
@othercorey othercorey deleted the 4.x-repl branch March 2, 2023 05:39
@markstory
Copy link
Member

either remove all or add all suggestions which are actual CakePHP plugin suggestions

Removing makes sense to me. We don't need to clutter people's applications with a bunch of commented out code when we also give them CLI tools to add the lines back in if required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants