-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4.x: remove loading repl plugin in bootstrap cli #941
Conversation
Isn't that what addOptionalPlugin is for? |
It is for dev dependencies ( Repl in not included neither in |
Sure, but it's the same concept. We could just comment it out I guess. |
By that logic we should then optionally load
as well |
Sure. If we're suggesting it. This is just a helpful template to show where things go, right. |
I am fine with either one of the solutions - either remove all or add all suggestions which are actual CakePHP plugin suggestions |
@ADmad what do you think? I don't have a strong opinion, just thought it could be used for this. |
I don't have a strong opinion on this either but would lean towards removing it. I don't remember anyone mentioning using the repl plugin in any of our help channels in a long time. |
Also one major gripe I have with the repl plugin / psysh is that it pulls in a symfony package which override our |
Sounds good, merging since this isn't a major issue. |
Removing makes sense to me. We don't need to clutter people's applications with a bunch of commented out code when we also give them CLI tools to add the lines back in if required. |
cakephp/repl isn't being installed by default anymore, therefore we shouldn't load it by default as well.
Refs: #878