chore: Add a CircleCI parameter for target publish-binary branch #32665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed value for branch - migrates trigger-publish-binary-pipeline.js to an inlined bash script to speed it up and simplify it - adds a pipeline parameter that can be set via CircleCI UI to determine which branch we use in the publish-binary pipeline, to reduce file churn and human error - updates the packages/electron/README.md to include the simplified steps
cacieprins
commented
Oct 7, 2025
| - [ ] Temporarily update the circle configuration to allow `cypress` to run against the branch | ||
| - [ ] Temporarily set target `cypress-publish-binary` branch as a `branch` property on the request body in [../../scripts/binary/trigger-publish-binary-pipeline.js](../../scripts/binary/trigger-publish-binary-pipeline.js) script, so that you can test against this branch from the electron upgrade branch. This property must be set both at the root of the body object, and on the `parameters` key. If it is not set at the root, the binary pipeline will continue to use the primary branch. | ||
| - [ ] Add your branch name to the `&full-workflow-filters` anchor in [`@pipeline.yml`](../../.circleci/src/pipeline/@pipeline.yml) |
There was a problem hiding this comment.
this can be parameterized as well (separately, to reduce delta surface)
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
cypress
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
ci/parameterize-binary-branch
|
| Run status |
|
| Run duration | 46m 54s |
| Commit |
|
| Committer | Cacie Prins |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
12
|
Pending
|
1102
|
Skipped
|
4
|
Passing
|
26601
|
| View all changes introduced in this branch ↗︎ | |
Warning
Partial Report: The results for the Application Quality reports may be incomplete.
UI Coverage
45.4%
|
|
|---|---|
|
Untested elements
|
185
|
|
Tested elements
|
158
|
Accessibility
97.97%
|
|
|---|---|
|
Failed rules
|
4 critical
8 serious
2 moderate
2 minor
|
|
Failed elements
|
101
|
Tests for review
cypress/e2e/studio/studio.cy.ts • 1 failed test • app-e2e
| Test | Artifacts | |
|---|---|---|
| Cypress Studio > updates an existing test with assertions |
Test Replay
Screenshots
|
|
e2e/origin/config_env.cy.ts • 1 flaky test • 5x-driver-electron
| Test | Artifacts | |
|---|---|---|
| cy.origin- Cypress.config() > serializable > overwrites different values in secondary if one exists in the primary |
Test Replay
|
|
issues/28527.cy.ts • 1 flaky test • 5x-driver-electron
| Test | Artifacts | |
|---|---|---|
| issue 28527 > fails and then retries and verifies about:blank is not displayed |
Test Replay
Screenshots
|
|
commands/window.cy.js • 1 flaky test • 5x-driver-chrome:beta
| Test | Artifacts | |
|---|---|---|
| ... > throws after timing out |
Test Replay
|
|
e2e/origin/config_env.cy.ts • 1 flaky test • 5x-driver-chrome:beta
| Test | Artifacts | |
|---|---|---|
| cy.origin- Cypress.config() > serializable > overwrites different values in secondary if one exists in the primary |
Test Replay
|
|
issues/28527.cy.ts • 1 flaky test • 5x-driver-chrome:beta
| Test | Artifacts | |
|---|---|---|
| issue 28527 > fails and then retries and verifies about:blank is not displayed |
Test Replay
Screenshots
|
|
The first 5 flaky specs are shown, see all 11 specs in Cypress Cloud.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
57afea5 to
5d50a15
Compare
| exit 1 | ||
| fi | ||
| echo "Determining next binary version..." | ||
| export NEXT_VERSION=$(node ./scripts/get-next-version.js) |
There was a problem hiding this comment.
Bug: Version Retrieval Mismatch Causes Incorrect Binary Version
The trigger-publish-binary-pipeline.yml command calls node ./scripts/get-next-version.js directly, expecting the version on stdout. This differs from the original logic, which called getNextVersionForBinary() from a module and extracted the version from its return. This change in how the version is obtained may result in an incorrect binary version.
<
6A4D
div id="issue-comment-box">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
This should reduce cognitive load regarding branches when performing Electron upgrades.
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?Note
Adds a
publish-binary-branchCircleCI parameter and replaces the Node trigger script with a bash-based CircleCI command, wiring it into the pipeline and updating Electron upgrade docs.publish-binary-branchpipeline parameter in.circleci/config.ymland.circleci/src/pipeline/@pipeline.yml.commands/trigger-publish-binary-pipeline.ymlto trigger thecypress-publish-binarypipeline (validates env/inputs, computes next version, triggers via API, persiststriggered_pipeline.json).create-and-trigger-packaging-artifactsto calltrigger-publish-binary-pipelinewithtarget-repo-branch: << pipeline.parameters.publish-binary-branch >>.scripts/binary/trigger-publish-binary-pipeline.jsand old inline trigger step.packages/electron/README.mdto use the new CircleCI parameterized flow for targeting the publish-binary branch.Written by Cursor Bugbot for commit 728b683. This will update automatically on new commits. Configure here.