improve test coverage #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxtim
commented
Aug 22, 2023
oliver-sanders
approved these changes
Oct 5, 2023
Co-authored-by: Oliver Sanders <oliver.sanders@metoffice.gov.uk>
MetRonnie
reviewed
Oct 17, 2023
tests/unit/test_rose_stem_units.py
Outdated
| assert result == ('foo', '', '', '', 'foo') | ||
|
|
||
|
|
||
| def test_process_multiple_auto_opts(monkeypatch, get_StemRunner): |
There was a problem hiding this comment.
I just test the code as is, it took me a few minutes to work out what it was trying to do. Now I don't like what it's trying to do: It doesn't raise an error if there is a mistake in the Rose user/global config.
I'm inclined to set up a new issue for that, what do you think?
MetRonnie
approved these changes
Oct 17, 2023
wxtim
added a commit
to wxtim/cylc-rose
that referenced
this pull request
Oct 24, 2023
Improve test coverage Co-authored-by: Oliver Sanders <oliver.sanders@metoffice.gov.uk>
wxtim
added a commit
to wxtim/cylc-rose
that referenced
this pull request
Oct 24, 2023
Improve test coverage Co-authored-by: Oliver Sanders <oliver.sanders@metoffice.gov.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial Response to #157, and partial replacement of #196
The aim from my point of view is to separate easy small changes from the need to refactor subprocess tests more thoroughly to work in a manner similar to Cylc's integration tests.
My checks on coverage suggest that this brings coverage from just over 95% to just under 99%
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).