[WIP] cmake: try untangling two no-install options #19144
Draft
+11
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[WIP]
Apparently there are two options to disable installs and/or exporting targets.
They both do overlapping and/or different things depending on
CMakeLists.txtfile. Also leaving one
install()outside both options.Try to figure out what their intent was and untangling / fixing them.
CURL_DISABLE_INSTALLaace27b cmake: option to disable install & drop
curlutarget when unused #12287CURL_ENABLE_EXPORT_TARGET8698825 Improve usability of CMake build as a sub-project #9638
643ec29 CMake: add CURL_ENABLE_EXPORT_TARGET option. #7060