setopt: refactor out the booleans from setopt_long to setopt_bool #17887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
bagder
added a commit
that referenced
this pull request
Jul 16, 2025
- add a message if a boolean is set to something not 1 or 0 (as it might be made to mean something else in a future) - use 's->' in all setopt_* functions Closes #17887
e88fe72 to
c013767
Compare
- add a message if a boolean is set to something not 1 or 0 (as it might be made to mean something else in a future) - use 's->' in all setopt_* functions Closes #17887
c013767 to
06af560
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add a warning if a boolean is set to something not 1 or 0 (as it might be made to mean something else in a future)
use 's->' in all setopt_* functions