fix(noRedundantUseStrict): keeps leading trivia #5868
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1c01f40 to
3b9f155
Compare
CodSpeed Performance ReportMerging #5868 will not alter performanceComparing Summary
|
siketyan
reviewed
May 4, 2025
ematipico
reviewed
May 9, 2025
| [], | ||
| )) | ||
| .build() | ||
| .with_leading_trivia_pieces(value_token.leading_trivia().pieces())?; |
There was a problem hiding this comment.
We should reuse the same trivia piece only if there are comments. If you check the snapshots, all of them have been updated. Instead of deleting the whole line, we remove the directive but we keep the indentation that belonged to the directive.
ematipico
approved these changes
Oct 15, 2025
Merged
ematipico
pushed a commit
that referenced
this pull request
Oct 15, 2025
This was referenced Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on
2EA2
deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes #5856
this pr creates a new node that has the same leading trivia as the old one, and then uses the new node to perform the action mutation.
Test Plan