Add --errexit flag to enable errexit in run commands #1118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set BATS_RUN_ERREXIT environment variable when flag is provided. Write $? to a temp file when errexit is enabled. Fixes bats-core#719 Fixes bats-core#748 Signed-off-by: Jan Dubois <jan@jandubois.com>
|
I believe I have addressed all failures found by CI related to the PR.
|
yes indeed, will take a look |
Signed-off-by: Jan Dubois <jan@jandubois.com>
|
I added another commit to the PR to make sure the tmp directory exists. Otherwise it can fail when This was already broken if you called |
jandubois
added a commit
to jandubois/rancher-desktop
that referenced
this pull request
Aug 22, 2025
Ref bats-core/bats-core#1118 Signed-off-by: Jan Dubois <jan.dubois@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$?to a temp file when errexit is enabled.I've tried for several hours, but have been unable to find a solution without using a temp file. I don't quite understand why, but I couldn't make it work.
Fixes #719
Fixes #748