-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP SOLR-16441: Upgrade Jetty to 11.x #1509
base: main
Are you sure you want to change the base?
Conversation
This is NOT ready to merge yet, but tagging some folks to at least look and see if this is something that we want to pursue. I think eventually we will need to go in this direction, but I don't think it needs to happen in Solr 9.x |
b74c178
to
4af6350
Compare
Will this be part of Solr 10? |
adc8d07
to
5f8d37d
Compare
@thomaswoeckinger no idea. this is updated to main now though. Still has the hadoop-auth and s3-repository modules disabled. |
Hi @risdenk Spring boot 3.0 and 3.1 use jetty 11x but Spring boot 3.2 will use jetty 12x. Maybe it would be more interesting to upgrade directly to jetty 12x, what do you think? Or release two versions, one with 11x and one with 12x? |
I would recommend to use Jetty 12. It allows to use both servlet APIs so we can stay with javax.servlet. You can run them in parallel, but actually a single context must use one version. SO means all of Solr needs to decide which version. I migarted one project here and it was great. There were some bugs in Jetty 12.0.0, but since 12.0.1 all worked fine. |
Let's rip that bandaid off and get to 12! Jakarta EE! |
I filed https://issues.apache.org/jira/browse/SOLR-17069 to look at Jetty 12.x |
https://issues.apache.org/jira/browse/SOLR-16441
This is just an example of what this might look like.
The changes are broken down like this approximately: