ZOOKEEPER-4966: Decouple ZKConfig from QuorumPeerConfig.ConfigException
#2306
+52
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The breaking change is source code level so it won't break runtime code. We could also make Give this pr and #2305, I could split |
868b004 to
5f4ae6f
Compare
5f4ae6f to
5e405ab
Compare
5e405ab to
ba49a73
Compare
…ption` `ZKConfig` is client accessible, it should avoid accessing server side `QuorumPeerConfig`. Changes: 1. Change method and constructor signatures of `ZKConfig` and `ZKClientConfig` to throw `o.a.zookeeper.common.ConfigException`. 3. Throw `QuorumPeerConfig.ConfigException` if it is in classpath. Given above changes, this pr maintain abi compatibility with old releases. **Breaking change**: methods and constructors of `ZKConfig` and `ZKClientConfig` throw `org.apache.zookeeper.common.ConfigException` now but not `QuorumPeerConfig.ConfigException`, so developers have to fix it to compile. This is a small step towards ZOOKEEPER-233. Refs: ZOOKEEPER-233, ZOOKEEPER-835, ZOOKEEPER-842, ZOOKEEPER-4970, ZOOKEEPER-4966.
ba49a73 to
c247522
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ZKConfigis client accessible, it should avoid accessing server sideQuorumPeerConfig.Changes:
org.apache.zookeeper.common.ConfigExceptionforZKConfig(String configPath).QuorumPeerConfig.ConfigExceptiona subclass of above.QuorumPeerConfig.ConfigExceptionif possible.Given above changes, this pr maintain abi compatibility with old releases.
Breaking change:
ZKConfig(String configPath)throwsorg.apache.zookeeper.common.ConfigExceptionnow but notQuorumPeerConfig.ConfigException, so developers have to fix it to compile.This is a small step towards ZOOKEEPER-233.
Refs: ZOOKEEPER-233, ZOOKEEPER-835, and ZOOKEEPER-842.