Use outputVar instead of hard coding this.output in JS codegen
#2950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is failing for this, but I'm incredibly unsure why or what's going wrong here. I'd greatly appreciate any assistance that folks could provide on this! EDIT: Yeah, Java's failing, but this doesn't touch the Java code o_o |
|
Please:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating the JS Thrift clients, it hard-codes
this.outputin a few places; however, ifgen_node_is true, our variable should beoutputinstead. We set a variable,outputVar, up on line 1968/1970 of the file, but don't use it everywhere. In NodeJS environment, this can lead to the wrong flush being called, which can lead to issues; for example, with the header transport protocol, the headers can either go missing or be sent incorrectly.I believe this is a trivial change not requiring a ticket.
If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?If your change does not involve any code, include[skip ci]anywhere in the commit message to free up build resources.