Nothing Special   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DRAFT] TEZ-4355: Unit test precommit improvements - full coverage #359

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[DRAFT] TEZ-4355: Unit test precommit improvements - full coverage #359

wants to merge 2 commits into from
+72 −967

Conversation

abstractdog
Copy link
Contributor

No description provided.

@tez-yetus

This comment was marked as outdated.

Sign in to view
@tez-yetus
Copy link

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-359/2/console in case of problems.

@tez-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 9s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
_ Patch Compile Tests _
+1 💚 shellcheck 0m 3s The patch generated 0 new + 0 unchanged - 144 fixed = 0 total (was 144)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
_ Other Tests _
+1 💚 asflicense 0m 51s The patch does not generate ASF License warnings.
1m 36s
Subsystem Report/Notes
Docker ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-359/2/artifact/out/Dockerfile
GITHUB PR #359
JIRA Issue TEZ-4355
Optional Tests dupname asflicense shellcheck shelldocs
uname Linux 8844f37da383 5.15.0-106-generic #116-Ubuntu SMP Wed Apr 17 09:17:56 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality build-tools/tez-personality.sh
git revision master / 30e9cdb
Max. process+thread count 51 (vs. ulimit of 5500)
modules C: . U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-359/2/console
versions git=2.34.1 maven=3.6.3 shellcheck=0.7.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@tez-yetus
Copy link

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-359/3/console in case of problems.

@tez-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 9s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗 mvndep 5m 23s Maven dependency ordering for branch
+1 💚 mvninstall 7m 44s master passed
+1 💚 compile 1m 43s master passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 💚 compile 1m 35s master passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
+1 💚 javadoc 1m 8s master passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 💚 javadoc 0m 59s master passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
_ Patch Compile Tests _
+0 🆗 mvndep 0m 7s Maven dependency ordering for patch
+1 💚 mvninstall 2m 36s the patch passed
+1 💚 compile 1m 43s the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 💚 javac 1m 43s the patch passed
+1 💚 compile 1m 34s the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
+1 💚 javac 1m 34s the patch passed
+1 💚 shellcheck 0m 1s The patch generated 0 new + 0 unchanged - 144 fixed = 0 total (was 144)
-1 ❌ whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚 xml 0m 1s The patch has no ill-formed XML file.
+1 💚 javadoc 0m 54s the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 💚 javadoc 0m 57s the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
_ Other Tests _
+1 💚 unit 4m 28s tez-dag in the patch passed.
-1 ❌ unit 64m 47s root in the patch failed.
+1 💚 asflicense 0m 45s The patch does not generate ASF License warnings.
97m 25s
Reason Tests
Failed junit tests tez.analyzer.TestAnalyzer
Subsystem Report/Notes
Docker ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-359/3/artifact/out/Dockerfile
GITHUB PR #359
JIRA Issue TEZ-4355
Optional Tests dupname asflicense shellcheck shelldocs javac javadoc unit xml compile
uname Linux 56081489a99d 5.15.0-106-generic #116-Ubuntu SMP Wed Apr 17 09:17:56 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality build-tools/tez-personality.sh
git revision master / 30e9cdb
Default Java Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
whitespace https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-359/3/artifact/out/whitespace-eol.txt
unit https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-359/3/artifact/out/patch-unit-root.txt
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-359/3/testReport/
Max. process+thread count 1523 (vs. ulimit of 5500)
modules C: tez-dag . U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-359/3/console
versions git=2.34.1 maven=3.6.3 shellcheck=0.7.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@abstractdog abstractdog changed the title TEZ-4355: Unit test precommit improvements - full coverage [DRAFT] TEZ-4355: Unit test precommit improvements - full coverage Aug 5, 2024
@ayushtkn
Copy link
Member

not sure what happened to TestAnalyzer, seems like broken, saw it at couple of more places as well...

@abstractdog
Copy link
Contributor Author

TestAnalyzer failure flakiness is tracked at TEZ-4565
other than that, this PR is still a draft, I haven't been able to get the pre-commit behavior that I wished
thanks for taking a look btw @ayushtkn , I'll let you know once this proceeds further

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abstractdog @tez-yetus @ayushtkn