-
Notifications
You must be signed in to change notification settings - Fork 23
feat: improve server errors handling #2638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2638 +/- ##
=======================================
Coverage 46.34% 46.34%
=======================================
Files 92 92
Lines 10819 10819
=======================================
Hits 5014 5014
Misses 5805 5805 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving but writing down that we will still need to investigate why the tests are making following tests fail.
Some tests with 'continue-on-error: true' have failed:
Created by continue-on-error-comment |
Timeout in Docker test step is due to another PR. Bypassing the failure and merging. |
resolves #2636
The server-side context on the error is moved to
Exception.__notes__
so the actual error message is kept minimal.