feat: exposing quantity types in PyDPF Core #1965
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1965 +/- ##
==========================================
+ Coverage 87.56% 88.60% +1.04%
==========================================
Files 90 90
Lines 10254 10271 +17
==========================================
+ Hits 8979 9101 +122
+ Misses 1275 1170 -105 |
cbellot000
approved these changes
Dec 12, 2024
| self._api.csfield_definition_fill_dimensionality(self, dim, nature, dim.internal_size) | ||
| return Dimensionality(dim.tolist(), natures(int(nature))) | ||
|
|
||
| def get_quantity_type(self, index=0): |
There was a problem hiding this comment.
Maybe having just one property which returns the quantity_types would be easier too use, what do you think?
cbellot000
approved these changes
Dec 13, 2024
|
[like] Camille Bellot reacted to your message:
________________________________
From: Alexandre Bouthéon ***@***.***>
Sent: Friday, December 13, 2024 9:34:58 AM
To: ansys/pydpf-core ***@***.***>
Cc: Camille Bellot ***@***.***>; Mention ***@***.***>
Subject: Re: [ansys/pydpf-core] feat: exposing quantity types in PyDPF Core (PR #1965)
[External Sender]
@a-bouth commented on this pull request.
________________________________
In src/ansys/dpf/core/field_definition.py<#1965 (comment)>:
+ raise ValueError("Index must be greater than or equal to 0")
+
+ quantity_type = self._api.csfield_definition_get_quantity_type(self, index)
+ return str(quantity_type)
+
+ def set_quantity_type(self, quantity_type):
+ """Setter for Quantity Type
+
+ Parameters
+ ----------
+ quantity_type: Quantity Type
+ Quantity type to set
+ """
+ self._api.csfield_definition_set_quantity_type(self, quantity_type)
+
+ def get_num_available_quantity_types(self):
@cbellot000<https://github.com/cbellot000> done
—
Reply to this email directly, view it on GitHub<#1965 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ATF7SHXXBBRJOOB67UUCIEL2FKS4FAVCNFSM6AAAAABTPFTM5KVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMBRHAZTSNBXGA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
…ys/pydpf-core into feat/exposing_quantity_types
…ys/pydpf-core into feat/exposing_quantity_types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposing the
quantity_typeforFieldsDefinitionMain Changes
field_definition_capi.pyfield_definition.py@propertydecorator forquantity_type, but it turns out that the getter needs an index, which we cannot specify with the@propertydecorator. I opted for defining explicitsget_quantity_type(index)andset_quantity_type()methods. Please let me know if I should do it differently.is_of_quantity_type()andget_num_quantity_types_available()test_field.py(I found other tests forFieldDefinitionhere, but maybe that's not the best place ?)Side changes
Enabling the cast of
FieldsContainerin theAnyclass