Fix SheetState Restoration for skipPartiallyExpanded #821
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR addresses an issue in the SheetState restoration logic. When skipPartiallyExpanded is set to true (e.g., based on configuration such as landscape mode), attempting to restore a PartiallyExpanded state could lead to errors due to the mismatch between the saved state and the new configuration. This change ensures that if skipPartiallyExpanded is true, a saved PartiallyExpanded value is restored as Expanded, preventing potential errors during configuration changes, such as device orientation switches.
Testing
To verify the changes, I tested the following scenario where a crash could occur:
(isLandscape = false)
, allowing the sheet to be set to PartiallyExpanded.(isLandscape = true)
, which sets skipPartiallyExpanded to true.