Simplify and improve previousBackStackEntry in NavController
#742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`asReversed` is used instead of `reversed` to reduce the cost of copying a list. The reversed list is converted to a `Sequence` earlier and `drop(1)` is used instead of the iterator to simplify the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Simplify and improve
previousBackStackEntryinNavControllerasReversedis used instead ofreversedto reduce the cost of copying a list. The reversed list is converted to aSequenceearlier anddrop(1)is used instead of the iterator to simplify the code.This change stems from the work done in Add
previousBackStackEntryFlowinNavControllerandNavController.previousBackStackEntryAsState#740. This change should also conflict with that PR. I can rebase/merge from that PR here, or rebase/merge from this PR in that PR if either of them is merged into the main branch first.Testing
Test: Run
./gradlew :navigation:navigation-runtime:connectedCheckin "playground-projects/navigation-playground"