Create ignore regex objects conditionally #2805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
kzantow
approved these changes
Jul 17, 2025
|
I had a similar thought -- we can iterate towards that 👍 (would need to have ignore-filters-first instead of rules in some of the top-level functionality, which is a larger refactor) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today a user can configure ignore rules based on package names, which can include regexp patterns. However, if you start including thousands of rules, it can take a lot of time creating those objects (where the bottleneck is the
regexp.Compile).This PR makes creating those objects conditional; if we detect if the package name is likely a regexp expression without compiling with a one-time-compiled regexp, then use that on each example ignore rule to generate either a custom regexp or a simple string comparison. This will help in cases where the user has a set of rules that are simple names instead of expressions.