performance: only check for a new DB once every 2 hours (configurable) #2148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
3963beb to
f2f6a94
Compare
willmurphyscode
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently grype will always reach out to check if there is a DB update, even if grype is run several times with in a short period of time. In reality we're only updating the DB once a day at this time, so checking for an update this frequently is fairly wasteful both client-wise and on the CDN.
This change adds a new
update-check-max-frequencywith a default of 2 hours. This only affects the scan path and notdb checkanddb updatepaths.This will also have the added value of reducing traffic spikes when we publish new databases, assuming most clients are not explicitly running
db update.