fix: correctly close the db file in v4/v5 stores #2066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kzantow
reviewed
Aug 19, 2024
Signed-off-by: Andrei Stefanie <andrei.stefanie@gmail.com>
kzantow
approved these changes
Aug 19, 2024
|
Thanks for the contribution, @AndreiStefanie |
willmurphyscode
added a commit
that referenced
this pull request
Aug 29, 2024
This reverts commit 589d86c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the closing of the DB file when calling the
Close()method.Before, the close method on the SQLite handler was never called. This leads to issues when running Grype as a server and trying to update the database on an NFS (because the files cannot be fully deleted until the process releases them - there will be a temporary file like
.nfs047ff9ac82cfe60d00000002)