fix: do not panic when given empty string arg #2064
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lucas Rodriguez <lucas.rodriguez9616@gmail.com>
spiffcs
approved these changes
Aug 19, 2024
There was a problem hiding this comment.
Thanks @lucasrod16 - great issue description, easy to reproduce, and awesome PR with the added test for regression protection.
I was able to reproduce this on latest grype, pulled your change, and ran with "" to verify the fix.
👍 🚀 Thank you very much for the bug fix!
@spiffcs Much appreciated! I really enjoy grype as a CLI and library user and appreciate the work that has been put into it. I'm glad to contribute back! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2063