Nothing Special   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE #12701] delete RpcClient.request() timeout check logic. #12702

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[ISSUE #12701] delete RpcClient.request() timeout check logic. #12702

wants to merge 1 commit into from

Conversation

XiaZhouxx
Copy link
Contributor

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

#12701

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.62%. Comparing base (3a9003b) to head (dadbc77).
Report is 6 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #12702      +/-   ##
=============================================
- Coverage      69.70%   69.62%   -0.08%     
+ Complexity      9431     9416      -15     
=============================================
  Files           1275     1275              
  Lines          41232    41231       -1     
  Branches        4374     4373       -1     
=============================================
- Hits           28740    28708      -32     
- Misses         10412    10446      +34     
+ Partials        2080     2077       -3
Files with missing lines Coverage Δ
.../alibaba/nacos/common/remote/client/RpcClient.java 91.18% <100.00%> (+0.88%) ⬆️

... and 29 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91987b0...dadbc77. Read the comment docs.

@KomachiSion
Copy link
Collaborator

Need more discussion, I think this codes should not be changed.

Please more discussion in issue.

@KomachiSion KomachiSion added the pending On hold due to dependency or release label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pending On hold due to dependency or release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@XiaZhouxx @codecov-commenter @KomachiSion