Ignore when config file is moved #8708
Merged
+7
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisduerr
requested changes
Oct 15, 2025
As this is practically the same as deleting the file it should be treated the same and ignored. Moving a file from somewhere to the config file is not ignored and the config will reload as normal. This fixes file not found errors when saving the config file in some editors. This doesn't consider the possible race condition where a modify and rename event both exist in the queue.
d9b3204 to
f13a094
Compare
chrisduerr
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As this is practically the same as deleting the file it should be treated the same and ignored.
Moving a file from somewhere to the config file is not ignored and the config will reload as normal.
This fixes file not found errors when saving the config file in some editors. This doesn't consider the possible race condition where a modify and rename event both exist in the queue.