Fix file not found errors when editing alacritty.toml #8707
Conversation
Alacritty monitors its config file and reloads as soon as any changes happen. This leads of "File not Found" errors being printed pretty much ever time I edit my config file. This turned out to be because on save vim moves the file, writes the changes and then moves it back. Aalacritty just happens to always try and write to the file while it's not there. This commit Adds special handling for renames and deletions. If either operation is currently the most recent event we discard the whole event queue with the assumption the file does not currently exist.
There was a problem hiding this comment.
This is a duplicate to at least one existing issue in the backlog. Editors that properly replace the configuration file do not struggle with this as far as I'm aware.
You're also relying on the queue containing both the removal and the new creation, which just seems like a wild guess? To me this seems like an unreliable way to fix a non-issue.
No this patch specifically looks for deletion / the file being renamed which in this situation is effectively deletion. If either of those things occur and the event is the last entry in the queue then we delete the queue. I think this is rather sane as, if the most recent event was a deletion we know the fire doesn't exist. Then it goes back to normal and we write again on the next normal event. If it was just editor shenanigans this probably won't be more than a second later. If the file really was deleted then probably a lot longer. Either way I believe this to be correct in all conditions. In regards to the text editor, I have no idea what's the general consensus on the correct way to go about things is. But if vim is doing it this way I assume it's not on accident and this behaviour isn't very uncommon. I understand this bug is really minor. However it occurs more than 50% of the time each time I write a save to my config file. It would be great if I didn't have to see the error message over and over. |
Alacritty monitors its config file and reloads as soon as any changes happen. This leads of "File not Found" errors being printed pretty much ever time I edit my config file.
This turned out to be because on save vim moves the file, writes the changes and then moves it back. Aalacritty just happens to always try and write to the file while it's not there.
This commit Adds special handling for renames and deletions. If either operation is currently the most recent event we discard the whole event queue with the assumption the file does not currently exist.