Adapt to SemigroupMonoid proposal #2036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First part of agda#2009. See https://prime.haskell.org/wiki/Libraries/Proposals/SemigroupMonoid. Already tested on GHC-7.8.4, 7.10.3, 8.0.1.
| -- but using that now gives warnings and doesn't silence -Wsemigroup | ||
| #if __GLASGOW_HASKELL__ >= 800 | ||
| {-# OPTIONS_GHC -Wno-semigroup #-} | ||
| #endif |
There was a problem hiding this comment.
See the related issue haskell/pretty#30.
There was a problem hiding this comment.
Thanks for the link! That means, hopefully, that before 8.2 this might be solved.
Or do you suggest an alternative solution here (though as a separate commit, I guess)?
In that direction, I now wonder whether this file could overload (<>) by defining a Semigroup instance, but it would have the wrong fixity.
However, this (<>) seems to also have an imperfect fixity, it seems to take the default infixl 9 (had to check https://www.haskell.org/onlinereport/decls.html) instead of pretty's infixl 6.
There was a problem hiding this comment.
Or do you suggest an alternative solution here (though as a separate commit, I guess)?
No.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First part of #2009.
See https://prime.haskell.org/wiki/Libraries/Proposals/SemigroupMonoid.
Already tested on GHC-7.8.4, 7.10.3, 8.0.1 locally; let's see if Travis agrees.