chore: remove unused typekit.js artifact from storybook #2956
Conversation
|
File metricsSummaryTotal size: 4.63 MB* 🎉 No changes detected in any packages * Size determined by adding together the size of the main file for all packages in the library.* Results are not gzipped or minified. * An ASCII character in UTF-8 is 8 bits or 1 byte. |
|
🚀 Deployed on https://pr-2956--spectrum-css.netlify.app |
There was a problem hiding this comment.
I looked back at the validation for #2930, and saw similar logging in the console still, which I believe is expected:
Sounds like there's already a Jira ticket to address all of that repetitive logging, and to ensure it loads the correct fonts on the contributing page. 👏
I did a search of the codebase for typekit.js. I found 2 references to a file of the same name, but both are related to the docs site and not storybook:
- in the
site/resources/jsdirectory, I seetypekit.js(there's a reference to this file also in thesite/READMEstructure depiction: https://github.com/adobe/spectrum-css/blob/main/site/README.md) - in
site/includes/dependencies.pug, there's a script loading that sametypekit.jsfile.
Like I said, I believe this typekit.js file is unrelated to the typekit.js file removed in this PR and storybook-related.
For now, I'm approving!
Description
Looks like remove the now unused typekit.js file from the .storybook/assets was missed in the Typography PR #2930.
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
To-do list