Nothing Special   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the attribute canShuffle #116

Closed
baubakg opened this issue Dec 13, 2022 · 1 comment · Fixed by #132
Closed

Remove the attribute canShuffle #116

baubakg opened this issue Dec 13, 2022 · 1 comment · Fixed by #132
Labels
enhancement New feature or request Refactoring Refactoring tasks
Milestone
8.0.0

Comments

@baubakg
Copy link
Member
baubakg commented Dec 13, 2022 •
edited
Loading

By default a phased test shuffles. If you add an event it is singleRun

Use Cases:

Nr category canShuffle Value PhaseEvent Before Result After Result Covered
1 legacy false existing Single Run Standard execution Single Run Standard execution testIsInSingleMode_STD
2 legacy false absent Test is executed as a Single Run with no break Test is not executed as a Phased test TestPhased#testSINGLE_whereNoPhaseEventHasBeenSet
3 legacy true absent Shuffled Run Standard Execution Shuffled Run Standard Execution testIsInSingleMode_Shuffled_Negative3
4 legacy true existing In this case the event is ignored We should treat it like a SingleRun. TestPhased#testSHUFFLE_wherePhaseEventHasBeenSet
5 new absent existing N/A Single Run Standard execution TestPhased#testFullMonty_SingleRun_newModel
6 new absent absent N/A Shuffled Run Standard Execution TestPhased#testSHUFFLED_FullMonty_newModel
@baubakg baubakg added enhancement New feature or request Refactoring Refactoring tasks labels Dec 13, 2022
@baubakg baubakg added this to the 8.0.0 milestone Dec 13, 2022
@baubakg
Copy link
Member Author
baubakg commented Feb 22, 2023

This requires setting the canShuffle to deprecated. By default we will shuffle.

baubakg added a commit that referenced this issue Mar 13, 2023
@baubakg
Fixed #116 : Deprecated the canShuffle method. Allowing now for defin…
7fa8698 
…ing single run by simply setting the @PhaseEven annotation
@baubakg baubakg mentioned this issue Mar 13, 2023
Merged
@baubakg baubakg linked a pull request Mar 13, 2023 that will close this issue
Fixed #116 : Deprecated the canShuffle method. Allowing now for defin… #132
Merged
baubakg added a commit that referenced this issue Mar 14, 2023
@baubakg
Fixed #116 : Deprecated the canShuffle method. Allowing now for defin… (
d96d6a9 
#132)

* Fixed #116 : Deprecated the canShuffle method. Allowing now for defining single run by simply setting the @PhaseEvent annotation
* Fixing javadoc issues
* Upgrading the cache in the GH actions
* Added the syntax for noninterruptive tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request Refactoring Refactoring tasks
Projects
None yet
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

Fixed #116 : Deprecated the canShuffle method. Allowing now for defin… adobe/phased-testing
1 participant
@baubakg