Convert active_admin_form_for to Arbre component - resolves #2542 #3486
Conversation
|
Can you add some examples into the readme and/or the docs |
|
Wow, awesome work. 😸 |
3a1e1bd to
259f2cd
Compare
|
Is the old way still supported? |
|
An the fist look it's great! 👍 Please apply my notes and make repush, to get more overview |
259f2cd to
774c5f0
Compare
|
I'm not sure, but c10a6c4 can bring problems to the developer. |
|
I think many users use def form_buffers
raise "`form_buffers` has removed from ActiveAdmin:: FormBuilder, please read https://github.com/activeadmin/activeadmin/blob/master/docs/5-forms.md for details."
end |
|
Agree about |
|
@timoschilling I added a backwardly compatible form_buffers method with a deprecation warning. |
|
I'd rather just raise an error. The next release is going to be 1.0.0, and we'll be following semantic versioning. I really don't want that cruft in the code base until 2.0.0 |
|
@varyonic nice work, but I have the same meaning as @seanlinsley |
474cfbd to
1a8fcf0
Compare
|
Moved backwardly compatible version of form_buffers to https://gist.github.com/varyonic/542c37648de91a02402a If anyone decides to use it please star and comment on the gist. |
1a8fcf0 to
d7e8d73
Compare
…ee PR activeadmin#3486 for discussion.
… an ERB template.
d7e8d73 to
c024ce3
Compare
c024ce3 to
3570bfa
Compare
|
@varyonic thanks for your great work on this!!! 👍 ❤️ |
…forms Convert active_admin_form_for to Arbre component - resolves #2542
form_buffers were removed in activeadmin/activeadmin#3486
Resolves #2542. Uses FormBuilderProxy as suggested by Igor in #2689, removing and replacing form_buffers from ActiveAdmin::FormBuilder. As a bonus allows 'inputs', etc. instead of 'f.inputs' in DSL. Allowing Arbre within has_many block deferred as a second step. May break existing code that mixes ERB inside active_admin_form_for in a template. Can also break other code that makes assumptions about the context of the block, see fix to active_admin_comments.rb included.