Fix non-blocking query/mutation execution #35
+356
−17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Task.async
instead of complexTask.Supervisor
approachOpentelemetryProcessPropagator.Task
for proper distributed tracingProblem
Previously, queries and mutations were blocking, allowing only one query in progress per connection. This was incorrect as each query should be able to be fired and asynchronously listen for its response, following a similar flow to subscriptions.
Solution
handle_query_or_mutation
function to useTask.async
for non-blocking executionOpentelemetryProcessPropagator.Task
when available for proper tracing context propagationQuerySupervisor
module that added complexity without benefitTest Results
All tests pass, including the specific
non_blocking_query_test.exs
that verifies:This brings query/mutation handling in line with how subscriptions work and matches what frontend transport layers expect.
🤖 Generated with Claude Code