refactor: drop networksetup downif command #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The network interfaces are setup by other packages' LaunchDaemon jobs and this command may conflict with their logic and configuration. We drop the command here in favor of these other tools as they're more accurately tuned for the specific instance type's environment. Signed-off-by: Jacob Vallejo <jakeev@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
n/a
Description of changes:
The network interfaces are setup by other packages' LaunchDaemon jobs and this command may conflict with their logic and configuration (which may differ by instance type - eg: mac1.metal vs mac2.metal).
We drop the command here in favor of these other tools as they're more accurately tuned for the specific instance types.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.