Create data directories #4
Conversation
Create data directories automatically. * Add flag to disable automatic creation.
3c2d086 to
d7538b6
Compare
8000
.travis.yml
Outdated
| - docker | ||
|
|
||
| # Ensure docker is updated | ||
| before_install: |
There was a problem hiding this comment.
I think we can actually remove this and just use
# Enable the docker service
services:
- docker
There was a problem hiding this comment.
Yea, the only thing it does now is upgrade docker.
There was a problem hiding this comment.
We could also add cache: pip to cache packages installed via pip
* Adds yamllint. * Use working docker images.
| privileged: true | ||
| volumes: | ||
| - /sys/fs/cgroup:/sys/fs/cgroup:ro | ||
| - name: minio-fedora-27 |
There was a problem hiding this comment.
Why do we depend on externally build docker images?
Can't something like that be implemented?
I know that it's not super efficient, but it makes the CI self-contained within the role.
There was a problem hiding this comment.
I think the test time efficiency was the goal. @paulfantom?
There was a problem hiding this comment.
Yes, I use those images to reduce time needed for CI pipeline. Those are automatically built from this repo https://github.com/paulfantom/dockerfiles
There was a problem hiding this comment.
@atosatto self-contained images are ok, but consider testing this across 3 versions of ansible and 5-6 distros (our basic test matrix, used for example here: https://github.com/cloudalchemy/ansible-prometheus), this will cause to build those images 15-18 times for every new commit. This takes a lot of time and doesn't scale well. Also this way when something breaks in one repo, we can quickly fix it for all of them.
There was a problem hiding this comment.
I did the same in the past (https://github.com/atosatto/dockerfiles) and then switched to self-contained images built as part of the CI project.
I am fine with the change for now. We can always switch back to Docker images built as part of the CI in a next stage.
travis: switch to python 3, test ansible 2.9
Create data directories automatically.