Adding the Author Bio to the TOC #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the logic of the XSL that generates the TOC to include the author bio in the TOC. This is done by changing the line excluding colophons to only exclude colophons if they do not contain the class abouttheauthor (this is standard for our boilerplate).
Now that we are including About the Author sections in the TOC, I updated the XSpec tests to match. To do this I added an additional test making sure that the abouttheauthor colophon section is included in the TOC, and adjusted the previous version of the test to indicate that colophons without an aboutheauthor class will continue to be excluded.
ruralocity
approved these changes
Nov 16, 2021
The functional part of the PR has been QAed on Staging (looks like I forgot to tag you on that PR). I added the xspec test for this one, but since it's a test only change I thought it could go straight to master. |
hackermatthew
approved these changes
Nov 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the logic of the XSL that generates the TOC to
include the author bio in the TOC. This is done by changing the
line excluding colophons to only exclude colophons if they do not
contain the class abouttheauthor (this is standard for our boilerplate).
It also updates our XSpec testing suite to match the new behavior.
This request comes from Kristen and is based on author complaints of
how the Author Bio displays on the UCV on the Platform.
https://intranet.oreilly.com/jira/browse/TOOLSREQ-7334
Re-requesting a review because I added the XSpec commit and the time elapsed since the earlier PR.