Add settings page and show quota usage and resource limits for the project #954
Conversation
|
|
| </dl> | ||
| <h2> | ||
| <span>Quota usage</span> | ||
| <a href="javascript:;" style="margin-left: 5px; cursor: pointer;" class="small pficon pficon-help" data-container="body" data-toggle="popover" data-placement="right" data-trigger="focus" data-content="Quota usage is aggregated for the whole project. Once the maximum for the project has been reached no more of that resource can be allocated within the project."></a> |
There was a problem hiding this comment.
@derekwaynecarr review this help message
There was a problem hiding this comment.
Does this render if and only if a quota is on for the project?
The message looks fine.
|
LGTM |
|
Also happens to fix https://bugzilla.redhat.com/show_bug.cgi?id=1190070 |
| <dd ng-if="project.displayName">{{project.displayName}}</dd> | ||
| <dd ng-if="!project.displayName"><em>No display name</em></dd> | ||
| <dt>Description:</dt> | ||
| <dd ng-if="project.metadata.annotations && project.metadata.annotations.description">{{project.metadata.annotations.description}}</dd> |
There was a problem hiding this comment.
is metadata.annotations.description a standard annotation? If so, should we make a filter to do this for us?
3755504 to
ec0880b
Compare
|
given the data from the API, I guess the units stuff is the best we can do |
| .filter('usageWithUnits', function() { | ||
| return function(value, type) { | ||
| // only special casing memory at the moment | ||
| var split = /([0-9]+)\s*(.*)/.exec(value); |
There was a problem hiding this comment.
will the amount ever include a decimal?
| </thead> | ||
| <tbody ng-repeat="limitRange in limitRanges"> | ||
| <tr ng-repeat-start="limit in limitRange.spec.limits"></tr> | ||
| <tr ng-repeat="(type, min) in limit.min"> |
There was a problem hiding this comment.
if min and max are not guaranteed to have the same set of resources, iterate over max to make sure we surface all max limits
|
LGTM |
…ject Also replace references to our custom $each with angular.forEach
|
[merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/892/) (Image: devenv-fedora_764) |
|
unrelated failure [merge] |
|
Evaluated for origin up to a11208b |
Merged by openshift-bot
No description provided.