Nothing Special   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.1] Add Go 1.23, drop 1.21 #4372

Merged
merged 1 commit into from
Aug 14, 2024
Merged

[1.1] Add Go 1.23, drop 1.21 #4372

merged 1 commit into from
Aug 14, 2024

Conversation

kolyshkin
Copy link
Contributor
@kolyshkin kolyshkin commented Aug 13, 2024 •
edited
Loading

As of commit 096e6f8 (PR #4299) we are ready for Go 1.23.

All that's left to do is:

  • Cirrus CI: switch from Go 1.21 to Go 1.22 (required to fix Cirrus CI)
  • GHA CI: drop go 1.21, add 1.23 to test matrix;
  • Dockerfile: switch from Go 1.21.x to 1.22.x.

@kolyshkin
[1.1] Add Go 1.23, drop 1.21
7f75aec 
As of commit 096e6f8 we are ready for Go 1.23.

All that's left to do is:
 - Cirrus CI: switch from Go 1.21 to Go 1.22;
 - GHA CI: drop go 1.21, add 1.23 to test matrix;
 - Dockerfile: switch from Go 1.21.x to 1.22.x.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@kolyshkin kolyshkin added this to the 1.1.14 milestone Aug 13, 2024
@kolyshkin kolyshkin marked this pull request as ready for review August 14, 2024 01:35
@kolyshkin kolyshkin added area/ci backport/1.1-pr A backport PR to release-1.1 labels Aug 14, 2024
@kolyshkin kolyshkin mentioned this pull request Aug 14, 2024
Merged
rata
rata approved these changes Aug 14, 2024
View reviewed changes
Copy link
Member
@rata rata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@AkihiroSuda AkihiroSuda merged commit f3f71a9 into opencontainers:release-1.1 Aug 14, 2024
28 checks passed
@github-actions github-actions bot mentioned this pull request Sep 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

@rata rata rata approved these changes

@lifubang lifubang Awaiting requested review from lifubang

@thaJeztah thaJeztah Awaiting requested review from thaJeztah

Assignees
No one assigned
Labels
area/ci backport/1.1-pr A backport PR to release-1.1
Projects
None yet
Milestone
1.1.14
Development

Successfully merging this pull request may close these issues.
3 participants
@kolyshkin @rata @AkihiroSuda