Try to delete exec fifo file when failure in creation #4319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rata
reviewed
Jun 10, 2024
455ce26 to
f7aa220
Compare
Signed-off-by: lifubang <lifubang@acmcoder.com>
f7aa220 to
e729452
Compare
rata
approved these changes
Jun 10, 2024
rata
reviewed
Jun 10, 2024
Has already deleted it if other logic in the caller fails.(Indeed only one caller at this time) |
kolyshkin
approved these changes
Jun 11, 2024
No, I have not seen any submit issues about this. So remove the backpaort label. |
rata
reviewed
Jun 11, 2024
Comment on lines
+426
to
+430
| defer func() { | ||
| if retErr != nil { | ||
| os.Remove(fifoName) | ||
| } | ||
| }() |
There was a problem hiding this comment.
Do you want to add a unit test for this? The value is questionable, though. Maybe on refactors it will help.
I think making mkfifo fail will just be a matter of removing the permissions on the statedir
kolyshkin
approved these changes
Jun 26, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a small possibility error after the exec fifo file has created, so we should try to delete it if we get an error from
createExecFifo.This is a possible bug discovered when doing code review, I think we have not meet it in daily usage.