Support Arbitrary Errors #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makes is a lot easier to support different error messages, and something that the library maintainer doesn't need to do. Introduces structured internal messages that handlers create. These structures are the encoded into JSON which Rollbar.com understands.
doc/writing_a_handler.md
Outdated
There was a problem hiding this comment.
What are the undefined fields there? What should I expect?
There was a problem hiding this comment.
These are messages coming from the error_logger. Will update the documentation with possible messages.
|
+1 |
and add it into the handler documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version of the message parsing and encoding made it hard to support other kinds of messages. This pull request changes how erollbar handles message and introduces the notion of handlers.
Handlers are funcitons with arity one that convert incoming messages from the
error_loggerto erollbars internal message structure using theerollbar_messageAPI. The library is then able to ship these internal messages out to Rollbar.com when needed.Handlers deprecate the filters, as handlers can choose to ignore messages and can as such double as filters.