Support versions of ffmpeg greater than 5 #3476
Conversation
Passing run #12248 ↗︎
Details:
Review all test suite changes for PR #3476 ↗︎ |
|||||||||||||||
|
Note: Ignore the conflicts, the web project was built for this PR just for testing. It will be reverted before it gets merged in. |
|
This pull request has not had any activity in 30 days. Since things move fast it's best to get PRs merged in. If this PR addresses a previously filed issue that needs to be resolved please work to get it merged in, or allow somebody else to work on a fix. This PR will be closed if no further activity occurs. Thank you for your contributions! |
|
Meer |
Could you add detail to your comment? |
2 failed tests on run #16078 ↗︎
Details:
|
||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Online readwrite chat embed > Show change name modal |
Screenshots
Video
|
|
| Online readwrite chat embed > Close name change modal |
Screenshots
Video
|
|
Review all test suite changes for PR #3476 ↗︎
|
I can't test this because the video configuration page is uninteractable due to loading |
|
Hi there, unfortunately this is paused. Please follow the thread over at #2071 for more details. |
|
Yes, I saw that, but in light of #2071 (comment) I was hoping I could provide something of use in the form of testing and feedback to the project. |
|
I appreciate you wanting to help, but please do read the rest to get up to date. This work is paused due to issues, and unfortunately testing and feedback isn't going to fix it at this point in time. But I do appreciate you wanting to help, and I hope you'll be wanting to help in other ways! #2071 (comment) |
|
This pull request has not had any activity in 30 days. If it has been abandoned no future actions are necessary, it will be automatically closed. If this is a PR with no clear plan on how to move forward on it getting into the project, then further discussion is needed. Now is a good time to discuss if this is still something that should be worked on. If this PR is idle simply because nobody has reviewed it, then feel free to ping somebody. However, if this PR is not linked to an existing issue regarding something that was previously determined to be important, then even more discussion needs to take place before it can get anywhere. This PR will be closed if no further activity occurs. Thank you for your contributions! |
|
Not stale. |
|
This pull request has not had any activity in 30 days. If it has been abandoned no future actions are necessary, it will be automatically closed. If this is a PR with no clear plan on how to move forward on it getting into the project, then further discussion is needed. Now is a good time to discuss if this is still something that should be worked on. If this PR is idle simply because nobody has reviewed it, then feel free to ping somebody. However, if this PR is not linked to an existing issue regarding something that was previously determined to be important, then even more discussion needs to take place before it can get anywhere. This PR will be closed if no further activity occurs. Thank you for your contributions! |
This splits out
vaapicodec into two completely different options.Vaapi (Legacy)is what has always existed in Owncast, and supports ffmpeg versions older than 5.Vaapiis the new, up-to-date support for Vaapi and requires support for ffmpeg v5 and above.When running this code it will migrate you from using
vaapitoVaapi (Legacy), making the assumption if you were using vaapi before you were also using an older version of ffmpeg. If you need to change it to the new version, you must manually make that change.