Install current workdir version of tools in devcontainer #3840
Conversation
There was a problem hiding this comment.
not sure about this one, we might still want to use the dev version in modules for example, where we lint based on that.
There was a problem hiding this comment.
We are changing the tag in devcontainer.json now for every release, like we did before. Is this why we don't need this code anymore?
There was a problem hiding this comment.
@mashehu : If we want the dev features somewhere let's keep it 👍
@mirpedrol : Not quite. If we change to installing whatever the current state (at a commit) is at devcontainer startup, this will automatically install the "dev" and "main" state if we run it from those branches ;) But it will also enable installing the state at a PR if you run codespaces from there.
There was a problem hiding this comment.
We should actually remove that step from the Checklist, as it will now be obsolete! We can always use the latest tag
Codecov Report✅ All modified and coverable lines are covered by tests. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
This reverts commit 89a028d.
…ch/nf-core-tools into issues/3837-impr-devcontainer
Closes #3837
nfcore/devcontainer:devimage as it will be obsolete with these changesPR checklist
CHANGELOG.mdis updateddocsis updated