allow mixed str and dict in lint config # 8000 3228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you write a quick test for this as well? |
…ix-yml-config-type
Joon-Klaps
reviewed
Oct 22, 2024
There was a problem hiding this comment.
Tried my best but am not entirely following with all changes due to a lack of knowledge on the codebase of nf-tools.
Tested it also again on my pipeline & new failed tests were popping up because actions_ci was not included in the class NFCoreYamlLintConfig(BaseModel
# Conflicts: # nf_core/utils.py # tests/pipelines/lint/test_nfcore_yml.py
…ix-yml-config-type
# Conflicts: # CHANGELOG.md # nf_core/pipelines/create/create.py
Codecov ReportAttention: Patch coverage is
Additional details and impacted files☔ View full report in Codecov by Sentry. |
mirpedrol
approved these changes
Dec 3, 2024
Co-authored-by: Júlia Mir Pedrol <mirp.julia@gmail.com>
|
Thanks @mashehu ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we should probably rewrite this into a TypedDict or similar in the future.