Add configurable prompt #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netromdk
requested changes
Oct 28, 2018
There was a problem hiding this comment.
Very nice and it works great. Maybe it could mention somewhere in the code what is supported to write int he REPL prompt? It's not so easy to show in the config file but at least we could show it as a comment aboe DEFAULT_REPL_PROMPT in config.py? And possibly write a page on the wiki about it, too.
|
Added comments. Yeah I was going to write a wiki entry for this once we agreed on the template identifiers and general implementation. |
netromdk
approved these changes
Oct 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First pass at allowing the repl prompt to be configured using a template string. The prompt configuration is set in the config file with the default template string
${ro}${w}>.Currently the prompt supports the following:
${ro}read-only mode. When Slacker is running in read-only mode this will be replaced with the contents ofread_only_strconfig variable (default =(read-only))${w}current workspace Slacker is using.Other identifiers could easily be supported using this method, as discussed in #76.
This is a pretty trivial implementation as it doesn't have any lexical analysis, strictly a string replace. If we want to support more complex logic we'd have to subclass the
Templateclass with our specific logic, or roll our own entirely.