Nothing Special   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore]: unified build tool to vite #983

Open
5 tasks done
BlackHole1 opened this issue Sep 29, 2021 · 1 comment
Open
5 tasks done

[chore]: unified build tool to vite #983

BlackHole1 opened this issue Sep 29, 2021 · 1 comment
Assignees
@crimx @hyrious @BlackHole1 @l1shen @Cheerego7
Labels
enhancement New feature or request pinned pinned issues or PR

Comments

@BlackHole1
Copy link
Collaborator
BlackHole1 commented Sep 29, 2021 •
edited by Cyberhan123
Loading

The current flat sub-project uses a different build tool:

we always knew it was confusing, but the good news is that we will remain unified in the future and will all switch to vite.

before switching to vite, we need to wait for the storybook to support vite builds

The storybook is still being optimized and there are still some issues with storybook-builder-vite(see:
storybookjs/builder-vite#2).

When they are finished, they will be ready for migration

other sub-projects can be migrated in one step first
@BlackHole1 BlackHole1 added enhancement New feature or request pinned pinned issues or PR labels Sep 29, 2021
@BlackHole1 BlackHole1 pinned this issue Sep 29, 2021
@hyrious
Copy link
Member
hyrious commented Jan 6, 2023

So far so good, the last thing preventing us to close this issue is storybook 7 (still in beta), which is meant to get rid of webpack completely.

The storybook library currently has been locked to some version to prevent react-router-dom version conflicting (5 vs 6) with the existing one in this repo. So the upgrading may not be easy.

Another annoying thing is we cannot turn off packages hoisting in https://github.com/netless-io/flat/blob/main/.npmrc#L2 because electron-builder does not support evaluating symlinks in file system (which is created by pnpm). Maybe @BlackHole1 could look into this in some day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crimx crimx

@hyrious hyrious

@BlackHole1 BlackHole1

@l1shen l1shen

@Cheerego7 Cheerego7

Labels
enhancement New feature or request pinned pinned issues or PR
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@crimx @hyrious @BlackHole1 @l1shen @Cheerego7