Nothing Special   »   [go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[discussion]: desktop/main-app #1300

Closed
4 of 5 tasks
Tracked by #983
Cyberhan123 opened this issue Jan 15, 2022 · 11 comments
Closed
4 of 5 tasks
Tracked by #983

[discussion]: desktop/main-app #1300

Cyberhan123 opened this issue Jan 15, 2022 · 11 comments
Assignees
Labels
stale Stale issues or PR

Comments

@Cyberhan123
Copy link
Contributor
Cyberhan123 commented Jan 15, 2022

We can use esbuild to accomplish this, the specific tasks still need to be investigated

  • Need support preload script
  • Need support hot-reload
  • Need support DotenvFlow
  • Need support ESLintPlugin
  • Need support Electron logger
@Cyberhan123 Cyberhan123 changed the title desktop/main-app de[discussion]: sktop/main-app Jan 15, 2022
@Cyberhan123 Cyberhan123 changed the title de[discussion]: sktop/main-app [discussion]: sktop/main-app Jan 15, 2022
@Cyberhan123 Cyberhan123 changed the title [discussion]: sktop/main-app [discussion]: desktop/main-app Jan 15, 2022
@Cyberhan123
Copy link
Contributor Author
Cyberhan123 commented Jan 18, 2022

@BlackHole1
Did I miss anything?And I don't have a good idea to make eslint and dot env flow support esbuild.Do you have any suggestions?

@BlackHole1
Copy link
Collaborator

@hyrious

@hyrious
Copy link
Member
hyrious commented Jan 18, 2022

There's nothing difficult to support them in esbuild, you can have a look at the plugin api: https://esbuild.github.io/plugins/#using-plugins

For example, the eslint plugin have to gather input files through onLoad or metafile, then invoke eslint; the dot env plugin have to modify initialOptions.define before everything goes.

@Cyberhan123
Copy link
Contributor Author

There's nothing difficult to support them in esbuild, you can have a look at the plugin api: https://esbuild.github.io/plugins/#using-plugins

For example, the eslint plugin have to gather input files through onLoad or metafile, then invoke eslint; the dot env plugin have to modify initialOptions.define before everything goes.

Thanks

@BlackHole1
Copy link
Collaborator

we don't need Electron logger

@stale
Copy link
stale bot commented Mar 20, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Stale issues or PR label Mar 20, 2022
@Cyberhan123 Cyberhan123 removed the stale Stale issues or PR label Mar 20, 2022
@stale
Copy link
stale bot commented May 19, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Stale issues or PR label May 19, 2022
@BlackHole1
Copy link
Collaborator

@Cyberhan123

@stale stale bot removed the stale Stale issues or PR label May 19, 2022
@Cyberhan123
Copy link
Contributor Author
Cyberhan123 commented May 20, 2022

@BlackHole1 I will finish this feature irecently, I have been busy with other things

@Cyberhan123
Copy link
Contributor Author

So far there is no good solution for esbuild eslint plugin, The eslint will case performance issues. So I suggest not to integrate it for now.
@hyrious @BlackHole1

@stale
Copy link
stale bot commented Aug 1, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Stale issues or PR label Aug 1, 2022
@stale stale bot closed this as completed Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Stale issues or PR
Projects
None yet
Development

No branches or pull requests

3 participants