Fix file-descriptor leak into the miou impl. spotted by httpcats #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks :) if you'd like a release, please let me know. maybe a release of only tls-miou-unix would be good? |
|
Yes, a release will be super useful :) . Not sure if it's easy to break the release cycle of all packages due to the |
|
I can manually do a release where the tls-miou-unix.1.0.1 has a bound to tls =1.0.0... |
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Aug 25, 2024
CHANGES: * tls-miou-unix: fix file descriptor leak (mirleft/ocaml-tls#508 @dinosaure) * tls-miou-unix: fix fuzz test (mirleft/ocaml-tls#507 @dinosaure)
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Aug 25, 2024
CHANGES: * tls-miou-unix: fix file descriptor leak (mirleft/ocaml-tls#508 @dinosaure) * tls-miou-unix: fix fuzz test (mirleft/ocaml-tls#507 @dinosaure)
avsm
pushed a commit
to avsm/opam-repository
that referenced
this pull request
Sep 5, 2024
CHANGES: * tls-miou-unix: fix file descriptor leak (mirleft/ocaml-tls#508 @dinosaure) * tls-miou-unix: fix fuzz test (mirleft/ocaml-tls#507 @dinosaure)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I spotted a file-descriptor leak on my
httpcats's test. The fix does not change the behavior oftls-miou-unixaboutreadandwriteafter ashutdown(the fuzzer should verify that) but ensure that we actually close the file-descriptor when we can.