DRAFT: yamlinclude initial commit #1038
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i80and
reviewed
Oct 16, 2023
|
|
||
| with open(path, "r") as file: | ||
| try: | ||
| yfile = yaml.safe_load(file) |
There was a problem hiding this comment.
Limit the try block to just this line
i80and
reviewed
Oct 16, 2023
| @@ -0,0 +1,96 @@ | |||
| import os.path | |||
There was a problem hiding this comment.
I would recommend running black on this file
i80and
reviewed
Oct 16, 2023
| # | ||
| # We parse that into a dictionary for lookup later as part of the substitution loop. | ||
| subs = {} | ||
| if ('subs') in self.options: |
There was a problem hiding this comment.
No need for parenthesis -- makes it look at first glance like you might be creating a tuple
i80and
reviewed
Oct 16, 2023
| # We parse that into a dictionary for lookup later as part of the substitution loop. | ||
| subs = {} | ||
| if ('subs') in self.options: | ||
| for i in self.options.get('subs').splitlines(): |
There was a problem hiding this comment.
Just self.options["subs"] is fine. get() is unnecessary
i80and
reviewed
Oct 16, 2023
|
|
||
| if ('debug') in self.options: print ("Substitution dictionary is "); print(subs) | ||
|
|
||
| key = self.options.get('key') |
There was a problem hiding this comment.
You probably want self.options["key"] unless you actually want to handle the case where key doesn't exist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just has the basic YAMLINCLUDE logic.
I have to figure out how best to use this. The place it might make the most sense is the absurdly long
common-mc-admin-config.rst, but before doing that I want to let #1028 complete.So for now will let this sit and think about whether this actually adds value to our workflow.