feat: support ftps reload certs without restart minio #21605
Closed
+62
−63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: support ftps reload certs without restart minio
klauspost
approved these changes
Sep 25, 2025
ramondeklein
reviewed
Oct 3, 2025
Comment on lines
+160
to
+162
| PreferServerCipherSuites: true, | ||
| MinVersion: tls.VersionTLS12, | ||
| NextProtos: []string{"ftp"}, |
There was a problem hiding this comment.
Should we add this too? Why not only override GetCertificate?
There was a problem hiding this comment.
Yesh. Those are ftps pkg added too
There was a problem hiding this comment.
It managed by certs management, that support hot reload certs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: support ftps reload certs without restart minio
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
With https://gitea.com/goftp/server/pulls/180 merged
now ftps can support custom
tls.configfix #21592
Motivation and Context
How to test this PR?
Types of changes
Checklist:
commit-idorPR #here)