Nothing Special   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error message to guide user fixing invalid parameter #518

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Improve error message to guide user fixing invalid parameter #518

merged 1 commit into from
Jul 18, 2023

Conversation

yah01
Copy link
Member
@yah01 yah01 commented Jul 18, 2023

/kind improvement

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Jul 18, 2023
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Jul 18, 2023
@codecov
Copy link
codecov bot commented Jul 18, 2023 •
edited
Loading

Codecov Report

Merging #518 (5d32fa4) into master (524c9ad) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #518   +/-   ##
=======================================
  Coverage   82.75%   82.75%           
=======================================
  Files          39       39           
  Lines        3519     3519           
=======================================
  Hits         2912     2912           
  Misses        498      498           
  Partials      109      109
Impacted Files Coverage Δ
entity/indexes_gen.go 100.00% <100.00%> (ø)
entity/indexes_search_param_gen.go 100.00% <100.00%> (ø)

@mergify mergify bot added the ci-passed auto merge needed label label Jul 18, 2023
@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Jul 18, 2023
@yah01
Improve error message to guide user fixing invalid parameter
5d32fa4 
Signed-off-by: yah01 <yang.cen@zilliz.com>
congqixia
congqixia approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor
@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Jul 18, 2023
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, yah01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the approved review approved label Jul 18, 2023
@sre-ci-robot sre-ci-robot merged commit bfb377d into milvus-io:master Jul 18, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia congqixia approved these changes

@sunby sunby Awaiting requested review from sunby

Assignees

@congqixia congqixia

Labels
approved review approved ci-passed auto merge needed label kind/improvement Changes related to something improve, likes ut and code refactor lgtm look good to me size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yah01 @sre-ci-robot @congqixia