Nothing Special   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature|Pick] Support Database for managing collection and index #501

Merged
merged 1 commit into from
Jun 28, 2023
Merged

[Feature|Pick] Support Database for managing collection and index #501

merged 1 commit into from
Jun 28, 2023

Conversation

chyezh
Copy link
Contributor
@chyezh chyezh commented Jun 26, 2023 •
edited
Loading

Related issue: #448
Pick from:
#449
#473
#478

@sre-ci-robot sre-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines. label Jun 26, 2023
@chyezh chyezh force-pushed the feature_database branch 2 times, most recently from b4bf5ea to 48cc86b Compare June 26, 2023 08:14
@chyezh
[Feature|Pick] Support Database for managing collection and index
f87db21 
Signed-off-by: chyezh <ye.zhen@zilliz.com>

Add connect RPC during establishing connection (milvus-io#478)

Signed-off-by: jaime <yun.zhang@zilliz.com>

Support API token config (milvus-io#473)

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@codecov
Copy link
codecov bot commented Jun 26, 2023 •
edited
Loading

Codecov Report

Merging #501 (f87db21) into master (06b4a4a) will decrease coverage by 0.49%.
The diff coverage is 63.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #501      +/-   ##
==========================================
- Coverage   84.09%   83.60%   -0.49%     
==========================================
  Files          36       38       +2     
  Lines        3319     3380      +61     
==========================================
+ Hits         2791     2826      +35     
- Misses        425      447      +22     
- Partials      103      107       +4
Impacted Files Coverage Δ
client/client.go 31.70% <27.77%> (-35.80%) ⬇️
client/connect.go 54.76% <50.00%> (-25.76%) ⬇️
client/config.go 65.21% <65.21%> (ø)
client/database.go 78.78% <78.78%> (ø)
client/interceptor.go 100.00% <100.00%> (+75.00%) ⬆️

... and 1 file with indirect coverage changes

@mergify mergify bot added the ci-passed auto merge needed label label Jun 26, 2023
@chyezh
Copy link
Contributor Author
chyezh commented Jun 26, 2023

/assign congqixia

@congqixia congqixia added the kind/feature Issues related to feature request from users label Jun 28, 2023
congqixia
congqixia approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor
@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Jun 28, 2023
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chyezh, congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the approved review approved label Jun 28, 2023
@sre-ci-robot sre-ci-robot merged commit ba2b896 into milvus-io:master Jun 28, 2023
@chyezh chyezh deleted the feature_database branch June 28, 2023 07:12
@chasingegg chasingegg mentioned this pull request Jul 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia congqixia approved these changes

@sunby sunby Awaiting requested review from sunby

Assignees

@congqixia congqixia

Labels
approved review approved ci-passed auto merge needed label kind/feature Issues related to feature request from users lgtm look good to me size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chyezh @sre-ci-robot @congqixia