Nothing Special   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add WithCollectionProperties option and support the back field name for PKs2Expr #400

Merged
merged 1 commit into from
Feb 20, 2023
Merged

add WithCollectionProperties option and support the back field name for PKs2Expr #400

merged 1 commit into from
Feb 20, 2023

Conversation

SimFG
Copy link
Contributor
@SimFG SimFG commented Feb 15, 2023

/kind improvement

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Feb 15, 2023
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Feb 15, 2023
@codecov
Copy link
codecov bot commented Feb 15, 2023 •
edited
Loading

Codecov Report

Merging #400 (e278f98) into master (47d534f) will decrease coverage by 0.11%.
The diff coverage is 60.00%.

❗ Current head e278f98 differs from pull request most recent head 6dd7ab7. Consider uploading reports for the commit 6dd7ab7 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #400      +/-   ##
==========================================
- Coverage   83.50%   83.40%   -0.11%     
==========================================
  Files          30       30              
  Lines        3044     3049       +5     
==========================================
+ Hits         2542     2543       +1     
- Misses        410      413       +3     
- Partials       92       93       +1
Impacted Files Coverage Δ
client/client_grpc_options.go 78.26% <0.00%> (-3.56%) ⬇️
client/client_grpc_data.go 72.32% <75.00%> (-0.24%) ⬇️

@mergify mergify bot added the ci-passed auto merge needed label label Feb 20, 2023
@SimFG @congqixia
add WithCollectionProperties option and support the back field name…
6dd7ab7 
… for `PKs2Expr`

Signed-off-by: SimFG <bang.fu@zilliz.com>
congqixia
congqixia approved these changes Feb 20, 2023
View reviewed changes
Copy link
Contributor
@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Feb 20, 2023
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, SimFG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the approved review approved label Feb 20, 2023
@sre-ci-robot sre-ci-robot merged commit f5d28d7 into milvus-io:master Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia congqixia approved these changes

@sunby sunby Awaiting requested review from sunby

Assignees

@congqixia congqixia

Labels
approved review approved ci-passed auto merge needed label kind/improvement Changes related to something improve, likes ut and code refactor lgtm look good to me size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SimFG @sre-ci-robot @congqixia